[
https://issues.apache.org/jira/browse/HADOOP-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-7947:
-------------------------------
Attachment: HADOOP-7947.001.patch
I tried to implement [~aw]’s comment.
Test cases will be attached later.
If no argument is given, all XML files in $HADOOP_CONF_DIR are verified.
{code}
[sekikn@mobile hadoop-3.0.0-SNAPSHOT]$ export
HADOOP_PREFIX=/Users/sekikn/hadoop-3.0.0-SNAPSHOT
[sekikn@mobile hadoop-3.0.0-SNAPSHOT]$ bin/hadoop conftest
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/capacity-scheduler.xml: valid
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/core-site.xml: valid
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/hadoop-policy.xml: valid
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/hdfs-site.xml: valid
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/httpfs-site.xml: valid
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/kms-acls.xml: valid
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/kms-site.xml: valid
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/yarn-site.xml: valid
OK
[sekikn@mobile hadoop-3.0.0-SNAPSHOT]$ echo $?
0
{code}
If some arguments are given, those files are verified.
{code}
[sekikn@mobile hadoop-3.0.0-SNAPSHOT]$ bin/hadoop conftest
etc/hadoop/log4j.properties
[Fatal Error] log4j.properties:1:1: Content is not allowed in prolog.
/Users/sekikn/hadoop-3.0.0-SNAPSHOT/etc/hadoop/log4j.properties: INVALID
Invalid file exists
[sekikn@mobile hadoop-3.0.0-SNAPSHOT]$ echo $?
1
{code}
I’m glad if someone reviews this patch.
> Validate XMLs if a relevant tool is available, when using scripts
> -----------------------------------------------------------------
>
> Key: HADOOP-7947
> URL: https://issues.apache.org/jira/browse/HADOOP-7947
> Project: Hadoop Common
> Issue Type: Wish
> Components: scripts
> Affects Versions: 2.7.0
> Reporter: Harsh J
> Labels: newbie
> Attachments: HADOOP-7947.001.patch
>
>
> Given that we are locked down to using only XML for configuration and most of
> the administrators need to manage it by themselves (unless a tool that
> manages for you is used), it would be good to also validate the provided
> config XML (*-site.xml) files with a tool like {{xmllint}} or maybe Xerces
> somehow, when running a command or (at least) when starting up daemons.
> We should use this only if a relevant tool is available, and optionally be
> silent if the env. requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
