[
https://issues.apache.org/jira/browse/HADOOP-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272832#comment-14272832
]
Allen Wittenauer commented on HADOOP-7947:
------------------------------------------
Cool! But a few things:
* It feels 'off' to me to actually read ${HADOOP_CONF_DIR} from the shell
environment. But given that Hadoop reads the xml files from the classpath, I
suppose this is really the only alternative. We should probably look at the
other parts of Hadoop that do this (read HADOOP_CONF_DIR... I know YARN does)
and make sure we're doing something similar. (e.g., is there a global constant
of HADOOP_CONF_DIR somewhere? Should there be?)
* We should probably support -conf here from the generic options parser bits.
This would make it trivial to support a "rolling" configuration dir-type
process, without having to muck with the shell environment while also being
consistent with the rest of Hadoop.
* If it's actually invalid XML (rather than not XML at all), does it show you
which property was broken?
> Validate XMLs if a relevant tool is available, when using scripts
> -----------------------------------------------------------------
>
> Key: HADOOP-7947
> URL: https://issues.apache.org/jira/browse/HADOOP-7947
> Project: Hadoop Common
> Issue Type: Wish
> Components: scripts
> Affects Versions: 2.7.0
> Reporter: Harsh J
> Labels: newbie
> Attachments: HADOOP-7947.001.patch
>
>
> Given that we are locked down to using only XML for configuration and most of
> the administrators need to manage it by themselves (unless a tool that
> manages for you is used), it would be good to also validate the provided
> config XML (*-site.xml) files with a tool like {{xmllint}} or maybe Xerces
> somehow, when running a command or (at least) when starting up daemons.
> We should use this only if a relevant tool is available, and optionally be
> silent if the env. requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
