[
https://issues.apache.org/jira/browse/HADOOP-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280258#comment-14280258
]
Steve Loughran commented on HADOOP-11463:
-----------------------------------------
-1
I want one minor change, which is the {close()}} operation must check for
transfers != null before doing its work. There's some stuff done in the
{{initialize()}} method before the field is assigned, so there's a risk that if
something went wrong there, close() would fail.
Once that's done I'll approve the patch
> Replace method-local TransferManager object with S3AFileSystem#transfers
> ------------------------------------------------------------------------
>
> Key: HADOOP-11463
> URL: https://issues.apache.org/jira/browse/HADOOP-11463
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: hadoop-11463-001.patch
>
>
> This is continuation of HADOOP-11446.
> The following changes are made according to Thomas Demoor's comments:
> 1. Replace method-local TransferManager object with S3AFileSystem#transfers
> 2. Do not shutdown TransferManager after purging existing multipart file -
> otherwise the current transfer is unable to proceed
> 3. Shutdown TransferManager instance in the close method of S3AFileSystem
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
