[
https://issues.apache.org/jira/browse/HADOOP-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287071#comment-14287071
]
Tsuyoshi OZAWA commented on HADOOP-11500:
-----------------------------------------
[~ted_yu] thanks for your contribution. The fix itself looks good to me.
Minor nits: How about moving line-trailing dots to head of the line like this?
I know that this is not related to the fix itself, but it's good timing to fix
it.
{code}
try (InputStream is = ApplicationClassLoader.class.getClassLoader()
.getResourceAsStream(PROPERTIES_FILE);) {
{code}
> InputStream is left unclosed in ApplicationClassLoader
> ------------------------------------------------------
>
> Key: HADOOP-11500
> URL: https://issues.apache.org/jira/browse/HADOOP-11500
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: hadoop-11500-001.patch
>
>
> {code}
> InputStream is = null;
> try {
> is = ApplicationClassLoader.class.getClassLoader().
> getResourceAsStream(PROPERTIES_FILE);
> {code}
> The InputStream is not closed in the static block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
