[ 
https://issues.apache.org/jira/browse/HADOOP-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288466#comment-14288466
 ] 

Arun Suresh commented on HADOOP-11492:
--------------------------------------

Hey [~kasha], Looks like a minor issue in your {{incrSharedConter()}} method 
(you should be calling trySetCount on {{sharedCount}} not 
{{delTokSeqCounter}}).. also dont think you need to do a 
sharedCount.getCount().. since you already have the versionedValue which has 
the count.

Also I guess the new Curator library handles paths a bit differently.. guess we 
need to modify the following :

{noformat}
  private static final String ZK_DTSM_SEQNUM_ROOT = "/ZKDTSMSeqNumRoot";
  private static final String ZK_DTSM_KEYID_ROOT = "/ZKDTSMKeyIdRoot";
  private static final String ZK_DTSM_TOKENS_ROOT = "/ZKDTSMTokensRoot";
  private static final String ZK_DTSM_MASTER_KEY_ROOT = "/ZKDTSMMasterKeyRoot";
{noformat}

And in the testcase, the leading path must be removed too :

{noformat}
   conf.set(ZKDelegationTokenSecretManager.ZK_DTSM_ZNODE_WORKING_PATH, 
"testPath");
{noformat}

> Bump up curator version to 2.7.1
> --------------------------------
>
>                 Key: HADOOP-11492
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11492
>             Project: Hadoop Common
>          Issue Type: Task
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: hadoop-11492-1.patch, hadoop-11492-2.patch
>
>
> Curator 2.7.1 got released recently and contains CURATOR-111 that YARN-2716 
> requires. 
> PS: Filing a common JIRA so folks from other sub-projects also notice this 
> change and shout out if there are any reservations. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to