[
https://issues.apache.org/jira/browse/HADOOP-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289747#comment-14289747
]
Hadoop QA commented on HADOOP-11450:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12694210/HADOOP-11450.004.patch
against trunk revision 24aa462.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-tools/hadoop-extras.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5467//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5467//console
This message is automatically generated.
> Cleanup DistCpV1 not to use deprecated methods and fix javadocs
> ---------------------------------------------------------------
>
> Key: HADOOP-11450
> URL: https://issues.apache.org/jira/browse/HADOOP-11450
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Tsuyoshi OZAWA
> Assignee: Varun Saxena
> Priority: Minor
> Attachments: HADOOP-11450.001.patch, HADOOP-11450.002.patch,
> HADOOP-11450.003.patch, HADOOP-11450.004.patch
>
>
> Currently, DistCpV1 is using deprecated methods and having wrong javadocs. We
> should fix them.
> 1. DistCpV1.copy doesn't have dstpath, but javadoc has it.
> {code}
> /**
> * Copy a file to a destination.
> * @param srcstat src path and metadata
> * @param dstpath dst path
> {code}
> 2. Removing deprecated methods.
> {code}
> SequenceFile.Writer dir_writer = SequenceFile.createWriter(jobfs,
> jobConf, dstdirlist, Text.class, FilePair.class,
> SequenceFile.CompressionType.NONE);
> {code}
> {code}
> basedir = args.basedir.makeQualified(basefs);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
