[
https://issues.apache.org/jira/browse/HADOOP-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292054#comment-14292054
]
Masatake Iwasaki commented on HADOOP-11498:
-------------------------------------------
Thanks for the comment [~ozawa].
bq. TraceSamplerFactory#createSampler don't throw RuntimeException with this
patch. As a result, traceSampler in DFSClient can be null:
TraceSamplerFactory#createSampler which returns the value of
o.a.htrace.SamplerBuilder#build does not return null but falls back to
NeverSampler on error. (NeverSampler means "never start tracing span" here.)
https://git-wip-us.apache.org/repos/asf?p=incubator-htrace.git;a=blob;f=htrace-core/src/main/java/org/apache/htrace/SamplerBuilder.java
In addition, TraceSamplerFactory#createSampler will create not only built-in
samplers such as NeverSampler, AlwaysSampler and ProbabilitySampler but user
defined samplers by the change.
I think these are desirable behaviours.
> Bump the version of HTrace to 3.1.0-incubating
> ----------------------------------------------
>
> Key: HADOOP-11498
> URL: https://issues.apache.org/jira/browse/HADOOP-11498
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Attachments: HADOOP-11498.001.patch
>
>
> The package is renamed from org.htrace to org.apache.htrace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
