[ 
https://issues.apache.org/jira/browse/HADOOP-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292406#comment-14292406
 ] 

Colin Patrick McCabe commented on HADOOP-11498:
-----------------------------------------------

Thanks for working on this, [~iwasakims]!

I think we can get rid of {{org.apache.hadoop.tracing.TraceSamplerFactory}} 
completely, and just use the {{SamplerFactory}} class in HTrace 3.1.0.  We also 
should not duplicate the {{wrapHadoopConf}} code from 
{{org.apache.hadoop.tracing.SpanReceiverHost}}.

Looks good aside from that!  I agree that createSampler will not return null.  
We were very careful about that because otherwise we would have to add null 
checks everywhere, which would be very annoying.

> Bump the version of HTrace to 3.1.0-incubating
> ----------------------------------------------
>
>                 Key: HADOOP-11498
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11498
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>         Attachments: HADOOP-11498.001.patch
>
>
> The package is renamed from org.htrace to org.apache.htrace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to