[
https://issues.apache.org/jira/browse/HADOOP-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292408#comment-14292408
]
Colin Patrick McCabe edited comment on HADOOP-11498 at 1/26/15 9:00 PM:
------------------------------------------------------------------------
Oh, and one more thing: can you get rid of the versions of
{{Span#addKVAnnotation}} that take {{byte[]}}? We'd like to remove those from
HTrace in the next release, and Hadoop not using them would make it much easier.
for example, this part in DFSClient.java:
{code}
TraceScope getSrcDstTraceScope(String description, String src, String dst) {
TraceScope scope = Trace.startSpan(description, traceSampler);
Span span = scope.getSpan();
if (span != null) {
if (src != null) {
span.addKVAnnotation(SRC,
src.getBytes(Charset.forName("UTF-8")));
}
if (dst != null) {
span.addKVAnnotation(DST,
dst.getBytes(Charset.forName("UTF-8")));
}
}
{code}
was (Author: cmccabe):
Oh, and one more thing: can you get rid of the versions of
{{addKeyValueAnnotation}} that take {{byte[]}}? We'd like to remove those from
HTrace in the next release, and Hadoop not using them would make it much easier.
> Bump the version of HTrace to 3.1.0-incubating
> ----------------------------------------------
>
> Key: HADOOP-11498
> URL: https://issues.apache.org/jira/browse/HADOOP-11498
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Attachments: HADOOP-11498.001.patch
>
>
> The package is renamed from org.htrace to org.apache.htrace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
