[
https://issues.apache.org/jira/browse/HADOOP-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293127#comment-14293127
]
Yi Liu commented on HADOOP-11469:
---------------------------------
Thanks Dian for update. One small nit, +1 after that and pending Jenkins:
{quote}
+import
org.apache.hadoop.crypto.key.kms.server.KeyAuthorizationKeyProvider.KeyOpType;
import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.util.StringUtils;
import java.io.File;
import java.net.MalformedURLException;
import java.net.URL;
+import java.util.Arrays;
{quote}
These imports are unnecessary, and can cause Jenkins javac warning.
> KMS should skip default.key.acl and whitelist.key.acl when loading key acl
> --------------------------------------------------------------------------
>
> Key: HADOOP-11469
> URL: https://issues.apache.org/jira/browse/HADOOP-11469
> Project: Hadoop Common
> Issue Type: Bug
> Components: kms
> Reporter: Dian Fu
> Assignee: Dian Fu
> Priority: Minor
> Attachments: HADOOP-11469.001.patch, HADOOP-11469.002.patch,
> HADOOP-11469.003.patch, HADOOP-11469.004.patch, HADOOP-11469.005.patch
>
>
> KMSACLs#setKeyACLs, loads key ACLs from the configuration by checking if the
> key name contains "key.acl". However, this also matches "default.key.acl" and
> "whitelist.key.acl" which is incorrect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
