[
https://issues.apache.org/jira/browse/HADOOP-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gera Shegalov updated HADOOP-11506:
-----------------------------------
Attachment: HADOOP-11506.003.patch
Thanks [~andrew.wang] for the thorough review.
I added tests for 3-variable resolution loops, and javdoc you requested, fixed
whitespaces.
You are right about "}" in afterRightBrace definition.
As for
{code}
bracePos > 0 && bracePos + "{c".length() < eval.length();
{code}
The intuition is: {{bracePos}} points to a left brace '{' of the minimum valid
var expression {{"$\{c}"}}. Thus, the closing right brace pos of the minimum
valid var is {{bracePos + "{c".length}}. Adding some more comments.
> Configuration.get() is unnecessarily slow
> -----------------------------------------
>
> Key: HADOOP-11506
> URL: https://issues.apache.org/jira/browse/HADOOP-11506
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Gera Shegalov
> Attachments: HADOOP-11506.001.patch, HADOOP-11506.002.patch,
> HADOOP-11506.003.patch
>
>
> Profiling several large Hadoop jobs, we discovered that a surprising amount
> of time was spent inside Configuration.get, more specifically, in regex
> matching caused by the substituteVars call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
