[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301718#comment-14301718
]
Hadoop QA commented on HADOOP-11104:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch
against trunk revision ffc75d6.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//console
This message is automatically generated.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
> checking
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-11104.001.patch
>
>
> Passing a negative value to the interval field of
> MetricsRegistry#newQuantiles should throw a MetricsException with a clear
> error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.hadoop.metrics2.lib.MutableQuantiles.<init>(MutableQuantiles.java:107)
> at
> org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like
> MetricsRegistry#newCounter() also have parameter checking for negative
> int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
