[
https://issues.apache.org/jira/browse/HADOOP-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-11526:
-----------------------------------
Component/s: native
Target Version/s: 2.7.0
Affects Version/s: 2.6.0
Hi Anu. Thank you for taking care of this. The patch looks good. However, I
also noticed that we have the same bug in both Bzip2Compressor.c and
Bzip2Decompressor.c. Could you please fix it in both places? The change will
be very similar to what you've already done in this patch. Thank you.
> Memory leak in Bzip2Decompressor
> --------------------------------
>
> Key: HADOOP-11526
> URL: https://issues.apache.org/jira/browse/HADOOP-11526
> Project: Hadoop Common
> Issue Type: Bug
> Components: io, native
> Affects Versions: 2.6.0
> Reporter: Ian Rogers
> Assignee: Anu Engineer
> Attachments: HADOOP-11526.001.patch
>
>
> The use of JNI's GetStringUTFChars should be paired with
> ReleaseStringUTFChars or else the utf-8 char* created by Java's JNI
> implementation is leaked. It isn't in Bzip2Decompressor.c:
> https://apache.googlesource.com/hadoop-common/+/refs/heads/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/bzip2/Bzip2Decompressor.c#45
> A less error-prone way of handling JNI resources like local references and
> UTF strings is to use a smart pointer like the Apache licensed code in
> Android's ScopedLocalRef and ScopedUtfChars:
> https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedLocalRef.h
> https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedUtfChars.h
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
