[ 
https://issues.apache.org/jira/browse/HADOOP-11541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308361#comment-14308361
 ] 

Zhe Zhang commented on HADOOP-11541:
------------------------------------

Thanks [~drankye] for the patch, great to see some real arithmetic logics 
coming in!
# {{XorRawDecoder}} and {{XorRawEncoder}} look good.
# It might not be a big deal now, but duplicating the logic between 2 versions 
of {{doDecode}} and {{doEncode}} is a little awkward. What's the downside of 
converting to a unified format first?
# {{TestCoderBase}} needs better documentation
#* What does {{getErasedIndexesForDecoding}} do? What is {{erasedDataIndexes}} 
for?
# All codec-agnostic methods can go into the base class
#* E.g., {{testCoding}} can be in {{TestCoderBase}}

> Raw XOR coder
> -------------
>
>                 Key: HADOOP-11541
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11541
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>             Fix For: HDFS-EC
>
>         Attachments: HADOOP-11541-v1.patch
>
>
> This will implement XOR codes by porting the codes from HDFS-RAID. The coder 
> in the algorithm is needed by some high level codecs like LRC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to