[ 
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-11512:
-----------------------------
    Attachment: HADOOP-11512.patch

Thanks Ryan. I've attached a cleaned up version that removes the extra changes 
to indentation made on some unrelated lines.

+1, will commit after Jenkins runs through this.

I also attached a tested branch-2 variant as the back-port was not 
straight-forward.

> Use getTrimmedStrings when reading serialization keys
> -----------------------------------------------------
>
>                 Key: HADOOP-11512
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11512
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 2.6.0
>            Reporter: Harsh J
>            Assignee: Ryan P
>            Priority: Minor
>         Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch, 
> HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch
>
>
> In the file 
> {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
>  we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) 
> which does not trim the input. This could cause confusing user issues if 
> someone manually overrides the key in the XML files/Configuration object 
> without using the dynamic approach.
> The call should instead use Configuration#getTrimmedStrings(…), so the 
> whitespace is trimmed before the class names are searched on the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to