[
https://issues.apache.org/jira/browse/HADOOP-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313022#comment-14313022
]
Hadoop QA commented on HADOOP-11512:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12697403/HADOOP-11512.patch
against trunk revision aab459c.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5635//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5635//console
This message is automatically generated.
> Use getTrimmedStrings when reading serialization keys
> -----------------------------------------------------
>
> Key: HADOOP-11512
> URL: https://issues.apache.org/jira/browse/HADOOP-11512
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 2.6.0
> Reporter: Harsh J
> Assignee: Ryan P
> Priority: Minor
> Attachments: HADOOP-11512.branch-2.patch, HADOOP-11512.patch,
> HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch, HADOOP-11512.patch
>
>
> In the file
> {{hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java}},
> we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…)
> which does not trim the input. This could cause confusing user issues if
> someone manually overrides the key in the XML files/Configuration object
> without using the dynamic approach.
> The call should instead use Configuration#getTrimmedStrings(…), so the
> whitespace is trimmed before the class names are searched on the classpath.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
