[ 
https://issues.apache.org/jira/browse/HADOOP-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321188#comment-14321188
 ] 

Hadoop QA commented on HADOOP-8642:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12698866/HADOOP-8642.5.patch
  against trunk revision 2efb234.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5692//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5692//console

This message is automatically generated.

> io.native.lib.available only controls zlib
> ------------------------------------------
>
>                 Key: HADOOP-8642
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8642
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Akira AJISAKA
>         Attachments: HADOOP-8642.2.patch, HADOOP-8642.3.patch, 
> HADOOP-8642.4.patch, HADOOP-8642.5.patch, HADOOP-8642.patch
>
>
> Per core-default.xml {{io.native.lib.available}} indicates "Should native 
> hadoop libraries, if present, be used" however it looks like it only affects 
> zlib. Since we always load the native library this means we may use native 
> libraries even if io.native.lib.available is set to false.
> Let's make the flag to work as advertised - rather than always load the 
> native hadoop library we only attempt to load the library (and report that 
> native is available) if this flag is set. Since io.native.lib.available 
> defaults to true the default behavior should remain unchanged (except that 
> now we wont actually try to load the library if this flag is disabled).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to