[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339254#comment-14339254
]
Chris Nauroth commented on HADOOP-11639:
----------------------------------------
FYI [~rusanu], since you had worked on YARN-2198. Here is the list of warnings
I see for a 64-bit compilation:
{code}
service.c(282): warning C4018: '<' : signed/unsigned mismatch
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(217): warning C4101: 'isSidDefaulted' : unreferenced local variable
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(327): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(385): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(440): warning C4047: 'function' : 'LPARAM' differs in levels of
indirection from 'void *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(440): warning C4024: 'CompareStringEx' : different types for formal
and actual parameter 9
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(503): warning C4026: function declared with formal parameter list
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(718): warning C4133: 'function' : incompatible types - from 'int *'
to 'size_t *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(740): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1117): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1117): warning C4020: 'AddNodeManagerAndUserACEsToObject' : too
many actual parameters
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1170): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1171): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1172): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1173): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1174): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1279): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1305): warning C4101: 'hr' : unreferenced local variable
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(172): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(240): warning C4029: declared formal parameter list different from
definition
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(285): warning C4133: 'function' : incompatible types - from 'LPSTR *'
to 'LPWSTR *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(312): warning C4133: 'function' : incompatible types - from 'int *' to
'size_t *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(339): warning C4018: '<' : signed/unsigned mismatch
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(445): warning C4133: 'function' : incompatible types - from 'LPSTR *'
to 'LPWSTR *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(631): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(699): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(726): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(740): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(879): warning C4133: 'function' : incompatible types - from 'char [2]'
to 'const wchar_t *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(879): warning C4996: '_wfopen': This function or variable may be
unsafe. Consider using _wfopen_s instead. To disable deprecation, use
_CRT_SECURE_NO_WARNINGS. See online help for details.
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
{code}
If I revert back to the last commit before YARN-2198, there are only 2 warnings:
{code}
task.c(362): warning C4133: 'function' : incompatible types - from 'char [2]'
to 'const wchar_t *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(362): warning C4996: '_wfopen': This function or variable may be
unsafe. Consider using _wfopen_s instead. To disable deprecation, use
_CRT_SECURE_NO_WARNINGS. See online help for details.
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
{code}
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Reporter: Chris Nauroth
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
