[ 
https://issues.apache.org/jira/browse/HADOOP-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347560#comment-14347560
 ] 

Brahma Reddy Battula commented on HADOOP-11613:
-----------------------------------------------

 *Testcase failures*  are because of {{encodedKey = URLEncoder.encode(key, 
"UTF-8");}} which is having the limitations on special characters..( All other 
characters are unsafe and are first converted into one or more bytes using some 
encoding scheme..Check the following java doc for same)

https://docs.oracle.com/javase/6/docs/api/java/net/URLEncoder.html

Just I replaced with bitset ( like following ), all the testcases are 
passing..I am always happy work with bitset..Hence I had given intial patch 
with bitset..

{code}
byte[] rawdata = URLCodec.encodeUrl(allowed_abs_path,
       EncodingUtils.getBytes(key, "UTF-8"));
 String encodedKey = EncodingUtils.getAsciiString(rawdata);
{code}

[~ajisakaa] If you agree with you, please consider initial patch which is 
having the bitset..( with this all the testcases are passing)..  Please correct 
me If I am wrong.

> Remove httpclient dependency from hadoop-azure
> ----------------------------------------------
>
>                 Key: HADOOP-11613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11613
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-11613-001.patch, HADOOP-11613-002.patch, 
> HADOOP-11613-003.patch, HADOOP-11613.patch
>
>
> Remove httpclient dependency from MockStorageInterface.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to