[ 
https://issues.apache.org/jira/browse/HADOOP-11643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348197#comment-14348197
 ] 

Li Bo commented on HADOOP-11643:
--------------------------------

hi, Kai
I think the code is ok in general.
One point:
When catching a {{NumberFormatException}}, {{IllegalArgumentException}} with 
message {{"No codec option is provided"}} is thrown. I think the codec option 
is provided but not in correct integer format, so how about changing the 
message like "Option XXX is an integer, please provide the correct format."

> Define EC schema API for ErasureCodec
> -------------------------------------
>
>                 Key: HADOOP-11643
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11643
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: io
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11643_v1.patch, HADOOP-11643_v2.patch
>
>
> As part of {{ErasureCodec}} API to be defined in HDFS-7699, {{ECSchema}} API 
> will be first defined here for better sync among related issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to