[
https://issues.apache.org/jira/browse/HADOOP-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350230#comment-14350230
]
Vinayakumar B commented on HADOOP-11646:
----------------------------------------
One nit for the latest patch.
For the below part, {code}+ ECBlock[] erasedBlocks = new ECBlock[numErased];
+ for (int i = 0; i < inputBlocks.length && i < erasedBlocks.length; i++) {
+ if (inputBlocks[i].isErased()) {
+ erasedBlocks[i] = inputBlocks[i];
+ }
+ }{code}
I expect as below,
{code}
+ ECBlock[] erasedBlocks = new ECBlock[numErased];
+ int j=0;
+ for (int i = 0; i < inputBlocks.length && j < erasedBlocks.length; i++) {
+ if (inputBlocks[i].isErased()) {
+ erasedBlocks[j++] = inputBlocks[i];
+ }
+ }{code}
> Erasure Coder API for encoding and decoding of block group
> ----------------------------------------------------------
>
> Key: HADOOP-11646
> URL: https://issues.apache.org/jira/browse/HADOOP-11646
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Fix For: HDFS-7285
>
> Attachments: HADOOP-11646-v4.patch, HDFS-7662-v1.patch,
> HDFS-7662-v2.patch, HDFS-7662-v3.patch
>
>
> This is to define ErasureCoder API for encoding and decoding of BlockGroup.
> Given a BlockGroup, ErasureCoder extracts data chunks from the blocks and
> leverages RawErasureCoder defined in HADOOP-11514 to perform concrete
> encoding or decoding. Note this mainly focuses on the basic fundamental
> aspects, and solves encoding, data blocks recovering and etc. Regarding
> parity blocks recovering, as it involves multiple steps, HADOOP-11550 will
> handle it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
