[
https://issues.apache.org/jira/browse/HADOOP-11673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Douglas updated HADOOP-11673:
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
+1 I committed this. Thanks, Brahma
> Use org.junit.Assume to skip tests instead of return
> ----------------------------------------------------
>
> Key: HADOOP-11673
> URL: https://issues.apache.org/jira/browse/HADOOP-11673
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-11673-001.patch, HADOOP-11673.patch
>
>
> We see the following code many times:
> {code:title=TestCodec.java}
> if (!ZlibFactory.isNativeZlibLoaded(conf)) {
> LOG.warn("skipped: native libs not loaded");
> return;
> }
> {code}
> If {{ZlibFactory.isNativeZlibLoaded(conf)}} is false, the test will *pass*,
> with a warn log. I'd like to *skip* this test case by using
> {{org.junit.Assume}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
