[ 
https://issues.apache.org/jira/browse/HADOOP-11673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353124#comment-14353124
 ] 

Hudson commented on HADOOP-11673:
---------------------------------

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2077 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2077/])
HADOOP-11673. Skip using JUnit Assume in TestCodec. (cdouglas: rev 
790aa6790edbbe6cefc9f9b554169d67e47f4200)
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> Use org.junit.Assume to skip tests instead of return
> ----------------------------------------------------
>
>                 Key: HADOOP-11673
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11673
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-11673-001.patch, HADOOP-11673.patch
>
>
> We see the following code many times:
> {code:title=TestCodec.java}
>     if (!ZlibFactory.isNativeZlibLoaded(conf)) {
>       LOG.warn("skipped: native libs not loaded");
>       return;
>     }
> {code}
> If {{ZlibFactory.isNativeZlibLoaded(conf)}} is false, the test will *pass*, 
> with a warn log. I'd like to *skip* this test case by using 
> {{org.junit.Assume}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to