[
https://issues.apache.org/jira/browse/HADOOP-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354251#comment-14354251
]
Hadoop QA commented on HADOOP-9646:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12587901/HADOOP-9646.002.patch
against trunk revision c3003eb.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5903//console
This message is automatically generated.
> Inconsistent exception specifications in FileUtils#chmod
> --------------------------------------------------------
>
> Key: HADOOP-9646
> URL: https://issues.apache.org/jira/browse/HADOOP-9646
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-9646.001.patch, HADOOP-9646.002.patch
>
>
> There are two FileUtils#chmod methods:
> {code}
> public static int chmod(String filename, String perm
> ) throws IOException, InterruptedException;
> public static int chmod(String filename, String perm, boolean recursive)
> throws IOException;
> {code}
> The first one just calls the second one with {{recursive = false}}, but
> despite that it is declared as throwing {{InterruptedException}}, something
> the second one doesn't declare.
> The new Java7 chmod API, which we will transition to once JDK6 support is
> dropped, does *not* throw {{InterruptedException}}
> See
> [http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#setOwner(java.nio.file.Path,
> java.nio.file.attribute.UserPrincipal)]
> So we should make these consistent by removing the {{InterruptedException}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
