[
https://issues.apache.org/jira/browse/HADOOP-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355720#comment-14355720
]
Allen Wittenauer commented on HADOOP-10752:
-------------------------------------------
{code}
+#elif defined(__aarch64__) // end x86 architecture
{code}
Minor nit: I'd really like for this to say that the ifdef is for ARM. At
least, I'd never guess that this was ARM without a hint/searching/pondering for
a while.
> Add support for hardware crc on ARM aarch64 architecture
> --------------------------------------------------------
>
> Key: HADOOP-10752
> URL: https://issues.apache.org/jira/browse/HADOOP-10752
> Project: Hadoop Common
> Issue Type: Improvement
> Components: native, performance
> Affects Versions: trunk-win
> Environment: ARM aarch64 Juno development platform
> Reporter: Edward Nevill
> Priority: Minor
> Labels: performance
> Attachments: jira-10752.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> This patch adds support for hardware crc for ARM's new 64 bit architecture.
> The patch is completely conditionalized on __arch64__
> For the moment I have only done the non pipelined version as the hw I have
> only has 1 crc execute unit.
> Some initial benchmarks on terasort give
> sw crc: 107 sec
> hw crc: 103 sec
> The performance improvement is quite small, but this is limited by the fact
> that I am using early stage hw which is not performant.
> I have also built it on x86 and I think the change is fairly safe for other
> architectures because post conditionalization the src is identical on other
> architectures.
> This is the first patch I have submitted for Hadoop so I would welcome any
> feedback and help.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
