[
https://issues.apache.org/jira/browse/HADOOP-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359408#comment-14359408
]
Chris Nauroth commented on HADOOP-11526:
----------------------------------------
Hello [~oae]. This bug would have been a small one-time leak per process
during codec initialization. There would not have been an additional leak per
file. I doubt the effect of this leak would have been noticeable in any
realistic usage scenario.
> Memory leak in Bzip2Compressor and Bzip2Decompressor
> ----------------------------------------------------
>
> Key: HADOOP-11526
> URL: https://issues.apache.org/jira/browse/HADOOP-11526
> Project: Hadoop Common
> Issue Type: Bug
> Components: io, native
> Affects Versions: 2.6.0
> Reporter: Ian Rogers
> Assignee: Anu Engineer
> Fix For: 2.7.0
>
> Attachments: HADOOP-11526.001.patch, HADOOP-11526.002.patch
>
>
> The use of JNI's GetStringUTFChars should be paired with
> ReleaseStringUTFChars or else the utf-8 char* created by Java's JNI
> implementation is leaked. It isn't in Bzip2Decompressor.c:
> https://apache.googlesource.com/hadoop-common/+/refs/heads/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/bzip2/Bzip2Decompressor.c#45
> A less error-prone way of handling JNI resources like local references and
> UTF strings is to use a smart pointer like the Apache licensed code in
> Android's ScopedLocalRef and ScopedUtfChars:
> https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedLocalRef.h
> https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedUtfChars.h
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
