[
https://issues.apache.org/jira/browse/HADOOP-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361361#comment-14361361
]
Aaron T. Myers commented on HADOOP-11714:
-----------------------------------------
Patch looks pretty good to me. My only suggestion is to put the two calls to
{{LOG.trace(...)}} in "{{if (LOG.isTraceEnabled)}}" blocks, if not for
performance then for consistency with the rest of the code base.
+1 once this is addressed. Thanks, Colin.
> Add more trace log4j messages to SpanReceiverHost
> -------------------------------------------------
>
> Key: HADOOP-11714
> URL: https://issues.apache.org/jira/browse/HADOOP-11714
> Project: Hadoop Common
> Issue Type: Improvement
> Components: tracing
> Affects Versions: 2.7.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-11714.001.patch
>
>
> Add more trace log4j messages to SpanReceiverHost
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
