[
https://issues.apache.org/jira/browse/HADOOP-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated HADOOP-7704:
-------------------------------------
Fix Version/s: (was: 3.0.0)
2.0.0-alpha
> JsonFactory can be created only once and used for every next request to
> create JsonGenerator inside JMXJsonServlet
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7704
> URL: https://issues.apache.org/jira/browse/HADOOP-7704
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Priority: Minor
> Fix For: 2.0.0-alpha
>
> Attachments: HADOOP-7704.patch, MAPREDUCE-3129.patch
>
>
> 1. Currently JMXJsonServlet creates JsonFactory for every http request.
> Its not efficient.
> JsonFactory can be created only once and used for every next request to
> create JsonGenerator.
> 2. Also following null check is not required.
> {code}
> if (mBeanServer == null) {
> jg.writeStringField("result", "ERROR");
> jg.writeStringField("message", "No MBeanServer could be found");
> jg.close();
> LOG.error("No MBeanServer could be found.");
> response.setStatus(HttpServletResponse.SC_NOT_FOUND);
> return;
> }
> {code}
> Because ManagementFactory.getPlatformMBeanServer(); will not return null.
> 3. Move the following code to finally so that any exception should not cause
> skipping of close method on JsonGenerator
> {code}
> jg.close();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
