[ 
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364466#comment-14364466
 ] 

Colin Patrick McCabe commented on HADOOP-8887:
----------------------------------------------

Please, -1 on automatic downloading of cmake.  The build takes long enough 
as-is, and cmake takes forever to download and install.  Plus we would have to 
somehow find the correct version for each different Linux distribution / BSD / 
Mac OS release, which puts this firmly in Not Happening territory.  And 
building cmake from source takes a really long time, maybe almost as much as 
Hadoop itself!  I don't remember exactly how long it took last time I did it.

I think we could move off of supporting cmake 2.6 in branch-2 today if we 
wanted to.  We only supported it earlier because people wanted to run on Red 
Hat 5, but that is no longer a concern.  We could bump the minimum version up 
to 2.8 and get rid of a bunch of quirks code.

> Use a Maven plugin to build the native code using CMake
> -------------------------------------------------------
>
>                 Key: HADOOP-8887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8887
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, 
> HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, 
> HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch
>
>
> Currently, we build the native code using ant-build invocations.  Although 
> this works, it has some limitations:
> * compiler warning messages are hidden, which can cause people to check in 
> code with warnings unintentionally
> * there is no framework for running native unit tests; instead, we use ad-hoc 
> constructs involving shell scripts
> * the antrun code is very platform specific
> * there is no way to run a specific native unit test
> * it's more or less impossible for scripts like test-patch.sh to separate a 
> native test failing from the build itself failing (no files are created) or 
> to enumerate which native tests failed.
> Using a native Maven plugin would overcome these limitations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to