[
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366469#comment-14366469
]
Hadoop QA commented on HADOOP-8320:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12705231/HADOOP-8320.002.patch
against trunk revision 968425e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.io.file.tfile.TestTFileByteArrays
org.apache.hadoop.fs.viewfs.TestFcPermissionsLocalFs
org.apache.hadoop.fs.shell.TestPathData
org.apache.hadoop.fs.TestChecksumFileSystem
org.apache.hadoop.crypto.key.TestKeyProviderFactory
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractDelete
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractSeek
org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.TestPath
org.apache.hadoop.util.TestGenericOptionsParser
org.apache.hadoop.crypto.key.TestKeyShell
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractAppend
org.apache.hadoop.fs.TestTrash
org.apache.hadoop.fs.TestS3_LocalFileContextURI
org.apache.hadoop.fs.TestLocalDirAllocator
org.apache.hadoop.security.alias.TestCredShell
org.apache.hadoop.fs.TestFileContextResolveAfs
org.apache.hadoop.io.TestMapFile
org.apache.hadoop.fs.shell.TestCopyPreserveFlag
org.apache.hadoop.fs.TestFsShellCopy
org.apache.hadoop.io.TestBloomMapFile
org.apache.hadoop.io.TestSecureIOUtils
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractOpen
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractMkdir
org.apache.hadoop.fs.shell.TestTextCommand
org.apache.hadoop.fs.viewfs.TestViewFsTrash
org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractMkdir
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractRename
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractDelete
org.apache.hadoop.fs.viewfs.TestFcMainOperationsLocalFs
org.apache.hadoop.fs.TestLocal_S3FileContextURI
org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.security.ssl.TestSSLFactory
org.apache.hadoop.io.TestSequenceFile
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays
org.apache.hadoop.io.TestSequenceFileSync
org.apache.hadoop.fs.TestLocalFSFileContextCreateMkdir
org.apache.hadoop.fs.TestFcLocalFsUtil
org.apache.hadoop.fs.TestStat
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractSeek
org.apache.hadoop.fs.TestLocalFSFileContextMainOperations
org.apache.hadoop.security.alias.TestCredentialProviderFactory
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractAppend
org.apache.hadoop.fs.viewfs.TestChRootedFs
org.apache.hadoop.fs.TestFileSystemCanonicalization
org.apache.hadoop.fs.TestFsShellReturnCode
org.apache.hadoop.fs.TestLocalFsFCStatistics
org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractLoaded
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractOpen
org.apache.hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
org.apache.hadoop.fs.contract.localfs.TestLocalFSContractCreate
org.apache.hadoop.fs.TestListFiles
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractRename
org.apache.hadoop.fs.TestFileUtil
org.apache.hadoop.fs.TestFcLocalFsPermission
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsJClassComparatorByteArrays
org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractCreate
org.apache.hadoop.fs.viewfs.TestChRootedFileSystem
org.apache.hadoop.fs.viewfs.TestViewFsLocalFs
org.apache.hadoop.fs.TestLocalFileSystem
org.apache.hadoop.io.TestSequenceFileSerialization
org.apache.hadoop.fs.TestFileContextDeleteOnExit
org.apache.hadoop.io.file.tfile.TestTFileSeqFileComparison
org.apache.hadoop.io.compress.TestCodec
org.apache.hadoop.security.TestLdapGroupsMapping
org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5964//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5964//console
This message is automatically generated.
> FileSystem#checkPath and AbstractFileSystem#checkPath should share code
> -----------------------------------------------------------------------
>
> Key: HADOOP-8320
> URL: https://issues.apache.org/jira/browse/HADOOP-8320
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Aaron T. Myers
> Assignee: Vijay Bhat
> Priority: Minor
> Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch
>
>
> Per the discussion on HADOOP-8310, these two methods can be refactored to
> share some code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
