[
https://issues.apache.org/jira/browse/HADOOP-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379758#comment-14379758
]
Hudson commented on HADOOP-11014:
---------------------------------
SUCCESS: Integrated in Hadoop-Yarn-trunk #877 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/877/])
HADOOP-11014. Potential resource leak in JavaKeyStoreProvider due to unclosed
stream. (ozawa) (ozawa: rev b351086ff66ca279c0550e078e3a9d110f3f36a5)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/JavaKeyStoreProvider.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java
> Potential resource leak in JavaKeyStoreProvider due to unclosed stream
> ----------------------------------------------------------------------
>
> Key: HADOOP-11014
> URL: https://issues.apache.org/jira/browse/HADOOP-11014
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.6.0
> Reporter: Ted Yu
> Assignee: Tsuyoshi Ozawa
> Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11014.1.patch, HADOOP-11014.2.patch,
> HADOOP-11014.3.patch, HADOOP-11014.4.patch
>
>
> From
> hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java
> :
> {code}
> private void writeToNew(Path newPath) throws IOException {
> FSDataOutputStream out =
> FileSystem.create(fs, newPath, permissions);
> try {
> keyStore.store(out, password);
> } catch (KeyStoreException e) {
> throw new IOException("Can't store keystore " + this, e);
> } catch (NoSuchAlgorithmException e) {
> throw new IOException(
> "No such algorithm storing keystore " + this, e);
> } catch (CertificateException e) {
> throw new IOException(
> "Certificate exception storing keystore " + this, e);
> }
> out.close();
> {code}
> IOException is not among the catch blocks.
> According to
> http://docs.oracle.com/javase/7/docs/api/java/security/KeyStore.html#store(java.io.OutputStream,%20char[]),
> IOException may be thrown from the store() call. In that case, out would be
> left unclosed.
> In loadFromPath():
> {code}
> keyStore.load(fs.open(p), password);
> {code}
> The InputStream should be closed upon return from load()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
