[
https://issues.apache.org/jira/browse/HADOOP-11664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383027#comment-14383027
]
Zhe Zhang commented on HADOOP-11664:
------------------------------------
Thanks Kai for the patch! The main logic looks good. Just 1 minor comment:
Is it necessary to configure the name of the xml file? I suggest we just hard
code the file name to simplify code.
{code}
+ public static final String IO_ERASURECODE_SCHEMA_FILE_KEY =
+ "hadoop.io.erasurecode.";
+ public static final String IO_ERASURECODE_SCHEMA_FILE_DEFAULT =
+ "ecschema-def.xml";
{code}
> Loading predefined EC schemas from configuration
> ------------------------------------------------
>
> Key: HADOOP-11664
> URL: https://issues.apache.org/jira/browse/HADOOP-11664
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-11664-v2.patch, HADOOP-11664-v3.patch,
> HDFS-7371_v1.patch
>
>
> System administrator can configure multiple EC codecs in hdfs-site.xml file,
> and codec instances or schemas in a new configuration file named
> ec-schema.xml in the conf folder. A codec can be referenced by its instance
> or schema using the codec name, and a schema can be utilized and specified by
> the schema name for a folder or EC ZONE to enforce EC. Once a schema is used
> to define an EC ZONE, then its associated parameter values will be stored as
> xattributes and respected thereafter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)