[
https://issues.apache.org/jira/browse/HADOOP-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383551#comment-14383551
]
Vinayakumar B commented on HADOOP-11627:
----------------------------------------
bq. 1. Would you remove the following code from TestTFileSeqFileComparison.java?
I wonder how compilation passed for this in QA?
bq. I'm thinking we can fix these failures by adding a setter method for
ZlibFactory.nativeZlibLoaded and setting the variable to false instead of just
removing conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY,
false). If we use the setter method, we should add @After method in the test to
reset the variable.
Thats a good idea. While resetting after test need to reset to its original
value (not just true). How about reloading, same as in static block. Do below
changes in ZLibfactory and calling {{ZlibFactory.loadNativeZLib}} in
{{@After}} method.
{code} static {
+ loadNativeZLib();
+ }
+
+ @VisibleForTesting
+ public static void loadNativeZLib() {
if (NativeCodeLoader.isNativeCodeLoaded()) {
nativeZlibLoaded = ZlibCompressor.isNativeZlibLoaded() &&
ZlibDecompressor.isNativeZlibLoaded();{code}
regarding patch, some nits
1. DeprecatedProperties.md can have the description as below. because the
property was not avoiding loading libs, but it was avoiding usage of them for
compression codecs.
{code}+| io.native.lib.available | NONE - By Default native libs will be used
for bz2 and zlib compression codecs if available. |{code}
2. {{TestConcatenatedCompressedInput.java}} also need similar treatment as
{{TestCodec}} to avoid failure when {{-Pnative}} specified.
> Remove io.native.lib.available from trunk
> -----------------------------------------
>
> Key: HADOOP-11627
> URL: https://issues.apache.org/jira/browse/HADOOP-11627
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-11627-002.patch, HADOOP-11627-003.patch,
> HADOOP-11627-004.patch, HADOOP-11627-005.patch, HADOOP-11627.patch
>
>
> According to the discussion in HADOOP-8642, we should remove
> {{io.native.lib.available}} from trunk, and always use native libraries if
> they exist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
