[ 
https://issues.apache.org/jira/browse/HADOOP-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481053#comment-14481053
 ] 

Vinayakumar B commented on HADOOP-11649:
----------------------------------------

One question I have is,

1. java ServiceLoader will load all the implementations of specified type in 
the entire classpath. Right? Will it miss any impl to load?
2. The codes specified via configurations also should be in the classpath to 
get successfully added. IMO these also will be already loaded by java 
ServiceLoader. right?
If all the codecs are loaded by ServiceLoader, then there is no need of 
configuration to add more codecs.

If the above is true, then
configuration to specify codes, can be used as a enabler to use only codecs 
specified in configuration, not all available in classpath( which are loaded  
by ServiceLoader).


Coming to patch,

1. conf name specified in {{public static final String IO_ERASURE_CODECS_KEY = 
"io.erasure.codecs";}} and {{core-default.xml}} are different.
2. ErasureCodec.java, when there is a explicit dependency mentioned on this 
Jira, then this class need not be included in the patch.
3. ErasureCodecLoader#load(..) should be changed based on the ans of above 
question
4. {{io.erasurecode.codec.rs.rawcoder}} adding this configuration seems 
unrelated to this Jira

> Allow to configure multiple erasure codecs
> ------------------------------------------
>
>                 Key: HADOOP-11649
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11649
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: io
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11649-v1.patch
>
>
> This is to allow to configure erasure codec and coder in core-site 
> configuration file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to