[ 
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486701#comment-14486701
 ] 

Allen Wittenauer commented on HADOOP-11746:
-------------------------------------------


 Console summary for previous Java example:

{noformat}


-1 overall

| Vote |           Subsystem |  Runtime  | Comment
|   0  |          pre-patch  |  08m 44s  | Pre-patch trunk compilation is 
|      |                     |           | healthy.
|  +1  |            @author  |  00m 00s  | The patch does not contain any 
|      |                     |           | @author tags.
|  -1  |     tests included  |  00m 00s  | The patch doesn't appear to include 
|      |                     |           | any new or modified tests. Please
|      |                     |           | justify why no new tests are needed
|      |                     |           | for this patch. Also please list what
|      |                     |           | manual steps were performed to verify
|      |                     |           | this patch.
|  -1  |         whitespace  |  00m 00s  | The patch has 1 lines that end in 
|      |                     |           | whitespace.
|  +1  |              javac  |  04m 09s  | There were no new javac warning 
|      |                     |           | messages.
|  +1  |            javadoc  |  05m 41s  | There were no new javadoc warning 
|      |                     |           | messages.
|  +1  |      release audit  |  00m 11s  | The applied patch does not increase 
|      |                     |           | the total number of release audit
|      |                     |           | warnings.
|  +1  |         checkstyle  |  03m 22s  | There were no new checkstyle issues. 
|  +1  |            install  |  01m 00s  | mvn install still works. 
|  +1  |    eclipse:eclipse  |  00m 22s  | The patch built with 
|      |                     |           | eclipse:eclipse.
|  -1  |           findbugs  |  00m 51s  | The patch appears to introduce 2 new 
|      |                     |           | Findbugs (version 3.0.1) warnings.
|  -1  |         core tests  |  01m 20s  | Tests failed in 
|      |                     |           | 
hadoop-yarn-project/hadoop-yarn/hadoop
|      |                     |           | -yarn-common.


             Reason | Tests
          FindBugs  |  FindBugs 
                    |  Unread public/protected field:At 
Log4jWarningErrorMetricsAppender.java:[line 44] 
          FindBugs  |  FindBugs 
                    |  Unread public/protected field:At 
Log4jWarningErrorMetricsAppender.java:[line 45] 
 Failed unit tests  |  Failed unit tests 
                    |  hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender 


|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12723637/MAPREDUCE-6301-002.patch
 |
| Optional Tests | javadoc javac unit checkstyle |
| git revision | f4b3fc5 / trunk |
| whitespace | /tmp/hadoop-test-patch/75950/whitespace.txt |
| Findbugs warnings | 
/tmp/hadoop-test-patch/75950/newPatchFindbugsWarningshadoop-yarn-common.html |
| hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common test log | 
/tmp/hadoop-test-patch/75950/testrun_hadoop-yarn-common.txt |
| Test Results | /testReport/ |
{noformat}

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, 
> HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, 
> HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, 
> HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, 
> HADOOP-11746-12.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to