[
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487777#comment-14487777
]
Colin Patrick McCabe commented on HADOOP-11789:
-----------------------------------------------
bq. 1. Xiaoyu Yao wrote: Is it possible to add additional check in the test for
the specific openssl version or above that we want to test. for example, parse
the 'openssl version -v' output.
Please, no. Openssl versioning is a mess. For example, Red Hat shipped a
library labelled 1.0.0 that was actually version 1.0.1e in RHEL6. With all the
vendor patching that goes on, it's very difficult to say what the actual
minimum version is for Hadoop, if it's even possible. We already handle this
correctly. If the library is too old, the dlsym calls will fail and the user
will get an informative message. We will only get ourselves into trouble if we
try to parse version IDs. (Which aren't even always numeric for openssl, a WTF
all its own.)
bq. 2. Can you add an Assert.assertTrue(codec!=null, "codec instance should not
be null!"); between the following two lines so that we will get meaningful
failure message instead of NPE when codec.getClass() is called with a null
instance.
Good idea. We should just use assertNotNull, though.
+1
> NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec
> -----------------------------------------------------
>
> Key: HADOOP-11789
> URL: https://issues.apache.org/jira/browse/HADOOP-11789
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.8.0
> Environment: ASF Jenkins
> Reporter: Steve Loughran
> Assignee: Yi Liu
> Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch
>
>
> NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on Jenkins
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
