[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507725#comment-14507725
]
Allen Wittenauer commented on HADOOP-11746:
-------------------------------------------
bq. Thoughts?
I think ignoring whitespace problems when pointed out is lazy, given how
relatively easy they are to fix. At this point, both git and test-patch are now
warning about this issue. If one is unmotivated to fix such a simple problem,
what else is getting ignored?
HowToContribute is actually pretty explicit about checkstyle errors. Patches
that violate it are supposed to be rejected. We've been lax in the past. It's
time to step up our vigilance and this is the first step. We certainly need to
improve the output here, but at least we're getting notified about them.
> rewrite test-patch.sh
> ---------------------
>
> Key: HADOOP-11746
> URL: https://issues.apache.org/jira/browse/HADOOP-11746
> Project: Hadoop Common
> Issue Type: Test
> Components: build, test
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Fix For: 2.8.0
>
> Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
> HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch,
> HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch,
> HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
> HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch,
> HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch,
> HADOOP-11746-18.patch, HADOOP-11746-19.patch, HADOOP-11746-20.patch,
> HADOOP-11746-21.branch-2.patch, HADOOP-11746-21.patch
>
>
> This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
