[
https://issues.apache.org/jira/browse/HADOOP-11802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509569#comment-14509569
]
Andrew Wang commented on HADOOP-11802:
--------------------------------------
Cool patch, only have nit-like stuff. +1 pending, though it is a lot of nits.
* There's CHANGES.txt included in the patch
* extra imports in DataXCeiver, though really you probably meant to add the
@Private annotation and just forgot.
* Add a newline in the DSW C file change, break the new POLLHUP check to the
next line (like the other if you changed). Adding a link to the webpage
reference (along with mentioning portability / Cygwin) would also be nice,
since I wondered why we didn't have to catch yet more poll errors.
* Typo "repsponse" in DataXceiver
* We typically have used a singleton to do fault injection, would be good to be
consistent since it doesn't look like we need per-instance injection. See
DataNodeFaultInjector, probably the best home.
* Good fix on the javadoc for allocSlot, but mind adding the blockId param doc
too for full coverage?
* The Throwable catch, it subsumes the IOException catch, so can we just delete
it? I think the more specific name of the exception will be printed by its
toString.
* Param indentation in TestSCCache#checkNumberOfSeg... is inconsistent, I think
we typically do double indent?
* TestSCCache, the comment "Remove the failure injector" should be moved up a
few lines
> DomainSocketWatcher thread terminates sometimes after there is an I/O error
> during requestShortCircuitShm
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11802
> URL: https://issues.apache.org/jira/browse/HADOOP-11802
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Eric Payne
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-11802.001.patch, HADOOP-11802.002.patch,
> HADOOP-11802.003.patch
>
>
> In {{DataXceiver#requestShortCircuitShm}}, we attempt to recover from some
> errors by closing the {{DomainSocket}}. However, this violates the invariant
> that the domain socket should never be closed when it is being managed by the
> {{DomainSocketWatcher}}. Instead, we should call {{shutdown}} on the
> {{DomainSocket}}. When this bug hits, it terminates the
> {{DomainSocketWatcher}} thread.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
