[
https://issues.apache.org/jira/browse/HADOOP-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512788#comment-14512788
]
Hadoop QA commented on HADOOP-9330:
-----------------------------------
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 6s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 24s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 19s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 5m 25s | There were no new checkstyle
issues. |
| {color:green}+1{color} | install | 1m 29s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 38s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 4s | Tests passed in
hadoop-common. |
| | | 45m 0s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12573149/HADOOP-9330-timeouts-1.patch
|
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / a00e001 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6180/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6180/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6180/console |
This message was automatically generated.
> Add custom JUnit4 test runner with configurable timeout
> -------------------------------------------------------
>
> Key: HADOOP-9330
> URL: https://issues.apache.org/jira/browse/HADOOP-9330
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Affects Versions: 3.0.0
> Reporter: Steve Loughran
> Attachments: HADOOP-9330-timeouts-1.patch
>
>
> HADOOP-9112 has added a requirement for all new test methods to declare a
> timeout, so that jenkins/maven builds will have better information on a
> timeout.
> Hard coding timeouts into tests is dangerous as it will generate spurious
> failures on slower machines/networks and when debugging a test.
> I propose providing a custom JUnit4 test runner that test cases can declare
> as their test runner; this can provide timeouts specified at run-time, rather
> than in-source.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)