[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514432#comment-14514432
 ] 

Jonathan Eagles commented on HADOOP-11866:
------------------------------------------

If further filter for checkstyle is needed beyond the current patch, we could 
consider the hunk line number ranges in the patch itself (Not the patch file 
itself, but the effective patch -> the diff after patch apply). Only checkstyle 
warnings within the lines should be considered to flag a patch as not 
checkstyle compliant. Using the same filter, a filtered version of the 
checkstyle output could be the artifact that will be used to eliminate to 
non-compliant code.

> increase readability of the output of white space and checkstyle script
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-11866
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11866
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Minor
>         Attachments: HADOOP-11866-checkstyle.patch, 
> HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch, 
> HADOOP-11866.20150427-1.patch
>
>
> HADOOP-11746 supports listing of the lines which has trailing white spaces 
> but doesn't inform patch line number. Without this report output will not be 
> of much help as in most cases it reports blank lines. Also for the first 
> timers it would be difficult to understand the output check style script 
> hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to