[
https://issues.apache.org/jira/browse/HADOOP-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522226#comment-14522226
]
Colin Patrick McCabe commented on HADOOP-11869:
-----------------------------------------------
+1 for fixing this. checkstyle has become very difficult to use, and basically
we are starting to ignore it because of all the false positives. We also
historically have not been that strict about whitespace in Hadoop. Is there a
convincing argument for changing this? To put it another way, how many actual
bugs have been caught by this thing?
> checkstyle rules/script need re-visiting
> ----------------------------------------
>
> Key: HADOOP-11869
> URL: https://issues.apache.org/jira/browse/HADOOP-11869
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Sidharta Seethana
>
> There seem to be a lot of arcane errors being caused by the checkstyle
> rules/script. Real issues tend to be buried in this noise. Some examples :
> 1. "Line is longer than 80 characters" - this shows up even for cases like
> import statements, package names
> 2. "Missing a Javadoc comment." - for every private member including cases
> like "Configuration conf".
> Having rules like these will result in a large number of pre-commit job
> failures. We should fine tune the rules used for checkstyle.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
