[
https://issues.apache.org/jira/browse/HADOOP-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525474#comment-14525474
]
Hadoop QA commented on HADOOP-6801:
-----------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 9s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 41s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 54s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 5s | The applied patch generated 6
new checkstyle issues (total was 450, now 455). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 43s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 53s | Tests passed in
hadoop-common. |
| | | 62m 1s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12729958/HADOOP-6801.05.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6419/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6419/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6419/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6419/console |
This message was automatically generated.
> io.sort.mb and io.sort.factor were renamed and moved to mapreduce but are
> still in CommonConfigurationKeysPublic.java and used in SequenceFile.java
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6801
> URL: https://issues.apache.org/jira/browse/HADOOP-6801
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Erik Steffl
> Assignee: Harsh J
> Priority: Minor
> Attachments: HADOOP-6801.05.patch, HADOOP-6801.r1.diff,
> HADOOP-6801.r2.diff, HADOOP-6801.r3.diff, HADOOP-6801.r4.diff,
> HADOOP-6801.r5.diff
>
>
> Following configuration keys in CommonConfigurationKeysPublic.java (former
> CommonConfigurationKeys.java):
> public static final String IO_SORT_MB_KEY = "io.sort.mb";
> public static final String IO_SORT_FACTOR_KEY = "io.sort.factor";
> are partially moved:
> - they were renamed to mapreduce.task.io.sort.mb and
> mapreduce.task.io.sort.factor respectively
> - they were moved to mapreduce project, documented in mapred-default.xml
> However:
> - they are still listed in CommonConfigurationKeysPublic.java as quoted
> above
> - strings "io.sort.mb" and "io.sort.factor" are used in SequenceFile.java
> in Hadoop Common project
> Not sure what the solution is, these constants should probably be removed
> from CommonConfigurationKeysPublic.java but I am not sure what's the best
> solution for SequenceFile.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
