[
https://issues.apache.org/jira/browse/HADOOP-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525485#comment-14525485
]
Hadoop QA commented on HADOOP-10318:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 40s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 23s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 41s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | tools/hadoop tests | 0m 51s | Tests passed in
hadoop-sls. |
| | | 36m 15s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12626263/HADOOP-10318.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| hadoop-sls test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/artifact/patchprocess/testrun_hadoop-sls.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6422/console |
This message was automatically generated.
> Incorrect reference to nodeFile in RumenToSLSConverter error message
> --------------------------------------------------------------------
>
> Key: HADOOP-10318
> URL: https://issues.apache.org/jira/browse/HADOOP-10318
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Wei Yan
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-10318.patch
>
>
> {code}
> if (! nodeFile.getParentFile().exists()
> && ! nodeFile.getParentFile().mkdirs()) {
> System.err.println("ERROR: Cannot create output directory in path: "
> + jsonFile.getParentFile().getAbsoluteFile());
> {code}
> jsonFile on the last line should be nodeFile
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
