[ 
https://issues.apache.org/jira/browse/HADOOP-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526170#comment-14526170
 ] 

Allen Wittenauer commented on HADOOP-11907:
-------------------------------------------

create-release.sh is one of the few that hasn't gotten rewritten yet.  It 
really needs a complete overhaul. So ironically, it's probably the one I'd 
recommend skipping. :D

We don't have unit tests for the shell code yet.  (There's a JIRA for that 
though.) So the best way to do this is to use the docker stuff to get a dev 
environment. This will give you a place to run test-patch.sh against any patch 
you build using 0.3.7 of shellcheck.

>From there, it's just run shellcheck against everything bash and fix the 
>errors.  Most of the errors that are left are relatively minor things or just 
>need to get the check disabled (hint: anything with ${HADOOP_OPTS} is a 
>disable, since we really do want it to split on ${IFS}.)

> update shell code to pass shellcheck 0.3.7
> ------------------------------------------
>
>                 Key: HADOOP-11907
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11907
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>              Labels: newbie
>         Attachments: HADOOP-11907.patch
>
>
> shellcheck 0.3.6 and 0.3.7 introduced some new checks which are now failing 
> the code base.  We should update the scripts to pass.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to