[ 
https://issues.apache.org/jira/browse/HADOOP-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526216#comment-14526216
 ] 

Jonathan Eagles commented on HADOOP-11883:
------------------------------------------

Pushing the unpack goal to beyond the test phase to not invoke this execution. 
Eclipse setup is still identical to the below instructions.

http://wiki.apache.org/hadoop/EclipseEnvironment

{code}
$ mvn install -DskipTests
$ mvn eclipse:eclipse -DdownloadSources=true -DdownloadJavadocs=true
{code}

Checkstyle is not invoke at build time since I haven't enabled that (by adding 
the project natures to the configuration). Checkstyle is now invoked in eclipse 
by installing checkstyle-cs and running checkstyle (right-click 
Checkstye->Check Code with Checkstyle) either per file or per package. The 
checkstyle errors and warnings are clickable and link to the source. Once this 
is in, it removes one more impediment for providing tools to the contributor 
and should help the reviewer focus on the patch beyond just formatting.

> Checkstyle Results are Different Between Command Line and Eclipse
> -----------------------------------------------------------------
>
>                 Key: HADOOP-11883
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11883
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: HADOOP-11883.1.patch, HADOOP-11883.2.patch
>
>
> If I run the checkstyle plugin from with eclipse, I want it to apply the same 
> rules as when run from the command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to