[
https://issues.apache.org/jira/browse/HADOOP-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528425#comment-14528425
]
Sean Busbey commented on HADOOP-11917:
--------------------------------------
{quote}
- ${GIT} clean -xdf
+ ${GIT} clean -xdf -e patchprocess/
{quote}
If someone passes in the cli arg for PATCH_DIR and it doesn't happen to be
"${BASE_DIR}/patchprocess", then this won't keep them safe. Probably best to
add a warning to the cli arg that says "this should not be within ${BASE_DIR}"
and leave this hold out as an undocumented feature. It's easy enough to set up
a jenkins workspace where the git repo and the patch dir sit next to each other
(for example, as done in the [work-in-progress nifi
job|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-NIFI-Build/])
> test-patch.sh should work with ${BASEDIR}/patchprocess setups
> -------------------------------------------------------------
>
> Key: HADOOP-11917
> URL: https://issues.apache.org/jira/browse/HADOOP-11917
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-11917.patch
>
>
> There are a bunch of problems with this kind of setup: configuration and code
> changes in test-patch.sh required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
