[ 
https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529763#comment-14529763
 ] 

Allen Wittenauer commented on HADOOP-11906:
-------------------------------------------

That.  Once I get test-patch.sh launching itself inside a Docker container, we 
can have a better a much more nuanced discussion around what security should be 
in place (esp since we'll able to control what binaries are actually being 
used).  But right now, it's kind of moot. 

> test-patch.sh should use 'file' command for patch determinism
> -------------------------------------------------------------
>
>                 Key: HADOOP-11906
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11906
>             Project: Hadoop Common
>          Issue Type: Test
>            Reporter: Allen Wittenauer
>            Assignee: Sean Busbey
>
> test-patch.sh currently restricts patches to the extension .patch.  It might 
> be useful to also check if the file command says it is a diff.  This would 
> allow us to determine if files that end in .txt are actually patches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to