[
https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530678#comment-14530678
]
Sean Busbey commented on HADOOP-11906:
--------------------------------------
Let's hope 'file' on jenkins does better than the on on OS X 10.8
{code}
$ file -version
file-5.04
magic file from /usr/share/file/magic
$ find ../patches/ -type f -exec file {} \; | cut -d: -f2 | sort | uniq -c |
sort -n -r
103 ASCII English text
82 diff output text
53 exported SGML document text
50 ASCII C++ program text
37 ASCII Java program text
27 RCS/CVS diff output text
23 HTML document text
23 ASCII text
10 ASCII English text, with very long lines
7 UTF-8 Unicode English text
3 ASCII C++ program text, with very long lines
2 data
2 PDF document, version 1.4
2 ASCII Java program text, with very long lines
1 UTF-8 Unicode English text, with very long lines
1 Git bundle
1 ASCII text, with very long lines
1 ASCII C++ program text, with CRLF, CR, LF line terminators
{code}
> test-patch.sh should use 'file' command for patch determinism
> -------------------------------------------------------------
>
> Key: HADOOP-11906
> URL: https://issues.apache.org/jira/browse/HADOOP-11906
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Allen Wittenauer
> Assignee: Sean Busbey
>
> test-patch.sh currently restricts patches to the extension .patch. It might
> be useful to also check if the file command says it is a diff. This would
> allow us to determine if files that end in .txt are actually patches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
