[
https://issues.apache.org/jira/browse/HADOOP-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531887#comment-14531887
]
Kai Zheng commented on HADOOP-11920:
------------------------------------
Hi Yi,
Thanks for your comments. The buffer should be DirectByteBuffer. Raw erasure
coders support two types of buffers: bytes array buffer and direct ByteBuffer.
As you may know, native coders would love more direct ByteBuffers for better
performance. In {{RawErasureCoder}}, it has:
{code}
/**
* Tell if direct buffer is preferred or not. It's for callers to
* decide how to allocate coding chunk buffers, using DirectByteBuffer or
* bytes array. It will return false by default.
* @return true if native buffer is preferred for performance consideration,
* otherwise false.
*/
public boolean preferDirectBuffer();
{code}
The Jenkins building failure was caused by my mistakenly committing of
HADOOP-11921. I have re-committed the patch and will trigger new building soon.
Yes it works for me to build it locally.
> Refactor some codes for erasure coders
> --------------------------------------
>
> Key: HADOOP-11920
> URL: https://issues.apache.org/jira/browse/HADOOP-11920
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-11920-HDFS-7285-02.patch,
> HADOOP-11920-HDFS-7285-v4.patch, HADOOP-11920-v1.patch,
> HADOOP-11920-v2.patch, HADOOP-11920-v3.patch
>
>
> While working on native erasure coders and also HADOOP-11847, it was found in
> some chances better to refine a little bit of codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
