[
https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534961#comment-14534961
]
Allen Wittenauer commented on HADOOP-11906:
-------------------------------------------
Fantastic. I threw it at all the patches that the current version had issues
with and it appears to do the correct thing. One nit: I don't think it's worth
the effort to make head replaceable since it doesn't have very many variants
that don't understand our syntax.
> test-patch.sh should use 'file' command for patch determinism
> -------------------------------------------------------------
>
> Key: HADOOP-11906
> URL: https://issues.apache.org/jira/browse/HADOOP-11906
> Project: Hadoop Common
> Issue Type: Test
> Reporter: Allen Wittenauer
> Assignee: Sean Busbey
> Attachments: HADOOP-11906.1.patch
>
>
> test-patch.sh currently restricts patches to the extension .patch. It might
> be useful to also check if the file command says it is a diff. This would
> allow us to determine if files that end in .txt are actually patches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
